Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: fix DraftDatasourceConfigAction #601

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

TrangPham
Copy link
Contributor

@TrangPham TrangPham commented Dec 21, 2024

Snowflake-sqlalchemy started returning dict_keys() instead of a list in latest version. Here is the change that did that snowflakedb/snowflake-sqlalchemy#556

Copy link
Collaborator

@billdirks billdirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.53%. Comparing base (2220f6b) to head (1cd5d7e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #601   +/-   ##
=======================================
  Coverage   86.53%   86.53%           
=======================================
  Files          25       25           
  Lines        1196     1196           
=======================================
  Hits         1035     1035           
  Misses        161      161           
Flag Coverage Δ
3.10 71.48% <100.00%> (ø)
3.11 71.48% <100.00%> (ø)
3.9 71.35% <100.00%> (ø)
integration 71.98% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TrangPham TrangPham merged commit c879696 into main Dec 23, 2024
16 of 17 checks passed
@TrangPham TrangPham deleted the fix-snowflake-sqlalchmey-table-reflection branch December 23, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants